Install custom app from URL and numbers in username

[scith]

Hello, While trying to test the Webmin app, I noticed that the URL could not be entered for installation. I suspect it has to do with the username of the creator containing numbers, because the fork made by someone without numbers worked.

Thanks

[opi]

Numbers are allowed for the username. See https://github.com/YunoHost/admin_js/blob/master/views/app/app_list.ms#L58

Can you please post the 2 urls, precising which one works and which one not. Thx

[scith]

Hum, I don't really get it but the links works on my production environment (debian dedicated server, using firefox on my client) but not on my virtual machine (debian as well using iceweasel on it). https://github.com/drfred1981/webmin_ynh does not work on my VM but https://github.com/yodaze/webmin_ynh does. https://github.com/Chao-Man/sickbeard_ynh does not work as well on my VM.

[opi]

Strange, it works on my side, but I use testing packages. You can try with the command line :

yunohost app install https://github.com/Chao-Man/sickbeard_ynh

[scith]

Hm yes it does work with Moulinette. Strange that it doesn't from the web browser of my VM though... But thanks I can use Moulinette for now then.

[opi]

It's because the web admin use a pattern (html5) on the url field to prevent not-github url to be entered. Btw, can you give me the pattern attributes of your github url field ?

[scith]

pattern="^https://github.com/[a-z-_]*/[a-z-_]*"

[opi]

Oh, you sure have an old version, the actual pattern is

pattern="^https://github.com/[a-zA-Z0-9-_]+/[a-zA-Z0-9-_]+[/]?$"

Is your YunoHost server up to date ? An maybe we miss an update on our side, and we need to release un update soon. Sorry, and thanks for pointing it out

[scith]

Oh thanks that should be it then! I should have an old version on my VM... Sorry about the fuss! Everything is working fine on my main server (which is up-to-date)

[opi]

thx for feedback