Yuri-SVB / Great_Wall

Protocol and application for providing Kerckhoffian, 0-trust, deviceless coercion-resistance in self-custody.
MIT License
24 stars 14 forks source link

Have iterations of the fractal formula be reused #61

Closed turizspace closed 8 months ago

turizspace commented 8 months ago

issue #30 fix

MuhammadMuradG commented 8 months ago

Hi, @turizspace!

Could you please add a description of the approach that this PR follow to solve the relegated issue? Also, the intention of the #30 was to enhance the performance of the app, so, is there an enhancement of performance? And can you give us a measure to this enhancement?

Last thing, we using a black with default configs to perform code formatting, so, keep stick with this please.

turizspace commented 8 months ago

@MuhammadMuradG Approach Taken: Implemented a caching mechanism (_iteration_cache) to store intermediate results of points computed during fractal generation. The caching mechanism checks if a point has been computed. If so, it retrieves the cached value instead of recomputing it.

Intention of Caching Mechanism:
    Enhance performance by avoiding redundant calculations during fractal generation.
    By storing intermediate results, previously computed values for points are reused, reducing computational overhead.

Measuring Performance Enhancement:
    Compare the execution time of the application before and after implementing the caching mechanism.
    Use profiling tools or timing functions within Python to measure the time taken for fractal generation.
    Run the fractal generation code with and without caching multiple times and average the results to obtain a measure of performance enhancement.
    Additionally, compare memory usage before and after implementing the caching mechanism to ensure memory efficiency.
MuhammadMuradG commented 8 months ago

So, is there was a performance enhancement after you applying the PR? And could you please report the results; we want to make sure that there is a real improvement in performance?

turizspace commented 8 months ago

@MuhammadMuradG please run the code on your dev env i can see you are a collaborator you can test whether there is improvements or not. I was asked to see the highway. this chunk of code was handed in for free. My more than 25hrs of work on it were not compensated so i am not reporting anything back from here. Thank you very much

MuhammadMuradG commented 8 months ago

In this project (Great Wall) we have a high standards that must be met before we merging code, specially because we are working on securing and encrypting information, so, we are very conservative about merging codes without making sure it produces what we intend from it.

It is considered best practices and a measure of developers professionalism to add a description for their submitted PRs and in the case of adding performance enhancement it is necessary to describe how much the performance has been enhanced instead of saying/claiming that this PR do..... And as you choose to work on this it is expected from you and not from someone else to do that, especially and as you mentioned this small chunk of code took 25 Hrs from you which means that you have plenty of time for this!!!

However, I run the code and it does not work and finally the application crashed!

MuhammadMuradG commented 8 months ago

We will close this as the contributor not intend to complete the implementation, unfortunately.

Feel free to reopen it if you want to work on it, and thanks for your valuable time.

MuhammadMuradG commented 8 months ago

Thank you for taking the time to comment, it seems you have time for that. This project is a collaborative effort with a mixed contribution model. We value contributions from all skill levels. We welcome anyone who wants to contribute in a honest, positive and constructive way.

However, we will report your comment that contains expressions of contempt, sarcasm, obscene gestures and false claims not supported by evidence.

turizspace commented 8 months ago

You should all be ashamed of yourselves. Delete all the comments all you like. It's a shame @MuhammadMuradG @Yuri-SVB next time pay 💰 devs better @AndreFGo image gonna report this organization on bitcoinerjobs dot com

MuhammadMuradG commented 8 months ago

@turizspace This is the last time I will warn you against doing such childish things, if you continue in that we will gonna blocking you permanently.