Yuri-SVB / Great_Wall

Protocol and application for providing Kerckhoffian, 0-trust, deviceless coercion-resistance in self-custody.
MIT License
24 stars 14 forks source link

Implement object-orianted class of TKBA params #82

Closed MuhammadMuradG closed 7 months ago

MuhammadMuradG commented 7 months ago

Changes description:

This PR add a layer of abstraction to the implementation of params that are used in the generation process of the tacit knowledge palettes.

The implementation provide an abstract class, called TacitKnowledgParam, that can serve as the parent class to support simple implementation of different tacit knowledge params. Now, we can define a specific tacit knowledge param by inherent from class TacitKnowledgeParam, and override _compute_value method to fit our new requirements of the new adopted tacit knowledge palettes.

What problem does this change solve?

As we intend to support different types of tacit knowledge palettes, this PR provide us with an easy way to implement and adapt different types of tacit knowledge.

Related issue:

54

Screen record for before and after the changes:

There is no visual changes in this PR, so, there will no be screen record attachment.

PR Checklist: