search

YuriGor / deepdash

eachDeep, filterDeep, findDeep, someDeep, omitDeep, pickDeep, keysDeep etc.. Tree traversal library written in Underscore/Lodash fashion
https://deepdash.io/
MIT License
272 stars 12 forks source link

Fix return type of findDeep, Add missing field to IDeepEntry #85

Closed casamia918 closed 3 years ago

casamia918 commented 3 years ago

I fixed return type of findDeep and add context field to IDeepEntry interface.

But, for now, the type of parent field of IDeepEntry is not IDeepEntry. It is just same with parent.value. It should be fix from the js source code, but I can't find where to fix it.

So I just add comment.

YuriGor commented 3 years ago

Hi, thank you for PR. parent arg should not be IDeepEntry. findDeep returns same set of data as passing into iteratee Here is a docs: https://deepdash.io/#iteratee "parentValue - an object or an array which contains current value"