YuriSizov / gdsion

A software synthesizer library for Godot (GDExtension).
Other
117 stars 2 forks source link

Extremely high notes produce corrupted sounds #10

Closed YuriSizov closed 6 months ago

YuriSizov commented 6 months ago

When playing notes above C9 (so starting with C#9) the output is noticeably corrupted, and doesn't match the sounds produced by the original SiON. The MIDI Grand Piano preset makes it very obvious, although other voices/instruments are also affected. This indicates a general error in the sound data generation.

The issue can be reproduced with the example project by playing on keys to the far right. Even without anything to compare you should notice that the rightmost C sounds fine, but C# and further contain some distortion. Low end of the note range doesn't seem to be affected (at least it sounds the same in the old SiON).

YuriSizov commented 6 months ago

Closed by https://github.com/YuriSizov/gdsion/commit/d667339e57280926b2897e704d93ef3fee57f1a3.