YusukeIwaki / playwright-ruby-client

Playwright client for Ruby
https://playwright-ruby-client.vercel.app/
MIT License
336 stars 34 forks source link

Add type signatures (RBS) #239

Closed navrocky closed 1 year ago

navrocky commented 1 year ago

It will be good to have type signatures (RBS) for all classes in this gem for code completion.

https://github.com/ruby/rbs

YusukeIwaki commented 1 year ago

@navrocky Could you provide actual code examples to indicate why type definition is wanted?

YusukeIwaki commented 1 year ago

@navrocky Initial implementation is added in 1.29.1. Please try it and let me know the feedback. Thank you.

navrocky commented 1 year ago

@YusukeIwaki thanx a lot, i'll try it as soon as i can!

navrocky commented 1 year ago

Yeah, code completion in RubyMine started working like a charm. Thank you!