Fix logic for launching Firefox >= 129

YusukeIwaki / puppeteer-ruby

A Ruby port of Puppeteer

Apache License 2.0

290 stars 41 forks source link

Fix logic for launching Firefox >= 129 #336

Closed YusukeIwaki closed 2 months ago

YusukeIwaki commented 2 months ago

resolves #335

Known issues:

The example code

page.goto('https://github.com/', wait_until: 'domcontentloaded')
page.wait_for_selector('[placeholder="Search or jump to..."]').click

raises an error "Evaluation failed: {"text"=>"call to Function() blocked by CSP"}"

This bug is also reprodusiblae with Puppeteer (JS) using Firefox on CDP. https://bugzilla.mozilla.org/show_bug.cgi?id=1650112

YusukeIwaki commented 2 months ago

It seems some site blocks evaluating JavaScript, however almost works. https://github.com/user-attachments/assets/f3ebceff-c0d6-433f-9008-05b63370951f

ryanckulp commented 2 months ago

thank you @YusukeIwaki ! this works great. can you PM me (dm@ryanckulp .com) so we can send you a bounty payment? my whole team really appreciates it.

YusukeIwaki commented 2 months ago

@ryanckulp Thank you for your kind offer. This library is an open-source project, and at this moment, it does not accept commercial funding. However, any support through GitHub Sponsorship is greatly appreciated.