Yutsuten / anki-lifedrain

Anki add-on that adds a life bar to anki while reviewing.
https://ankiweb.net/shared/info/715575551
GNU Affero General Public License v3.0
23 stars 2 forks source link

Background color of the life drain bar and Night-mode #22

Closed NicolasCuri closed 5 years ago

NicolasCuri commented 5 years ago

Hey, man! I have a small suggestion:

Is it possible to make an automatic change in the background color when I toggle my night mode? This way I don't have to change the background color of my life drain bar every time I toggle night mode on.

Image demonstrating: https://imgur.com/a/OGvqCjA

What do you think? Or should I ask this to the owner/developer of the Night-mode add-on? Thanks! :)

NicolasCuri commented 5 years ago

By the way, I'm using the background colors:

F0F0F0 ⇒ Normal

444444 ⇒ Night mode

Yutsuten commented 5 years ago

You like to toggle things eh...

I don't like the idea of putting some code into my add-on that depends on the implementation of another add-on. Not everyone who uses Life Drain uses Night Mode.

I use Night Mode myself, but it is on by default. I feel no need to add a toggle colors. You may want to change only the bar's background, but another person may want to change all colors. This can become pretty complicated just because of an integration.

The options to change the bar's style were made to solve this problem. I did my best to make it easily changeable. Is it that difficult for you to toggle the background color manually?

Yutsuten commented 5 years ago

Changing your suggestion a little, but if we change our focus from Night Mode to simply the window's background color, an option to sync the bar's background color with the window's color sounds better.

NicolasCuri commented 5 years ago

Hahaha, my bad! I'm a medical student, and I've been using Anki for >6h/day consistently for ~1year now. It is my main source of knowledge acquisition, so I use it a lot, and changing my study environment keeps me motivated to go through a shit ton of reviews (today I have 1600 cards to go through - my cards accumulated due to med school duties). Changing manually is not a problem at all, but since Night Mode is one of the most popular add-ons out there, this can make things aesthetically and functionally better, imho. Thanks for considering my request, you've been extremely helpful to me and to my productivity.

Yutsuten commented 5 years ago

Oh I see...

Changing automatically would really be nice, but to what color? Night Mode's color can be changed. Adding a new menu asking for a bar background color when Night Mode is installed AND on doesn't sound good for me.

Are you nice with the modification I wrote earlier? About an option to sync the bar's background color with the window's color.

NicolasCuri commented 5 years ago

I think these would be nice:

F0F0F0 ⇒ Normal (default)

444444 ⇒ Night mode.

Linking the background color of the bar with the window's color (background color of a card) doesn't seem like a good idea since I know lots of people that have shared decks with different card stylings. So they would have their bars changed every time they have a card with a different styling.

I don't want to waste your time; it is just a small suggestion to consider! :)

Yutsuten commented 5 years ago

You're misunderstanding the meaning of window's color. It is NOT the background color of a card. Or else installing Night Mode wouldn't be necessary, just set the background of the card to the color you want. You certainly know the card's background color has a much more limited area.

Anyway, we're thinking on the same thing and explaining with different words. I'm just being more generic. I'll see what I can do about it.

NicolasCuri commented 5 years ago

Ha! Ok! My bad :) Looking forward to it.