Rifkat6519 commented 4 years ago

Hi! Sorry for bad English. Why library does not see my guitar processor RP-355(composite usb device)?

I connect my RP-355 to the PC (usbview.exe) and show(fragment):

Interface Descriptor: bInterfaceNumber: 0x07 =7 bAlternateSetting: 0x00 bNumEndpoints: 0x02 bInterfaceClass: 0x01 (Audio) ++ buf_ptr[5] ==USB_CLASS_AUDIO bInterfaceSubClass: 0x03 (MIDI Streaming) ++buf_ptr[5] ==USB_CLASS_AUDIO bInterfaceProtocol: 0x00 iInterface: 0x04 0x0409: "DigiTech RP355 MIDI" 0x0409: "DigiTech RP355 MIDI"
Next, I start sketch "Usb_Desc", and show:

=== Start 01

String Descriptors: Manufacturer: DigiTech Product: DigiTech RP355

Device descriptor: Descriptor Length: 12 Descriptor type: 01 USB version: 0110 Device class: 00 Device Subclass: 00 Device Protocol: 00 Max.packet size: 08 Vendor ID: 1210 Product ID: 001D Revision ID: 0001 Mfg.string index: 01 Prod.string index: 02 Serial number index: 00 Number of conf.: 01 Total length truncated to 256 bytes Configuration descriptor: Total length: 0160 Num.intf: 05 Conf.value: 01 Conf.string: 02 Attr.: 80 Max.pwr: 00

Interface descriptor: Intf.number: 00 Alt.: 00 Endpoints: 00 Intf. Class: 01 Intf. Subclass: 01 Intf. Protocol: 00 Intf.string: 03 Unknown descriptor: Length: 0A Type: 24 Contents: 01000134000201020C24 Unknown descriptor: Length: 0C Type: 24 Contents: 020101010002030000030924 Unknown descriptor: Length: 09 Type: 24 Contents: 030203060001030C24 Unknown descriptor: Length: 0C Type: 24 Contents: 020303060002030000030924 Unknown descriptor: Length: 09 Type: 24 Contents: 030401010003030904

Interface descriptor: Intf.number: 01 Alt.: 00 Endpoints: 00 Intf. Class: 01 Intf. Subclass: 02 Intf. Protocol: 00 Intf.string: 03

Interface descriptor: Intf.number: 01 Alt.: 01 Endpoints: 01 Intf. Class: 01 Intf. Subclass: 02 Intf. Protocol: 00 Intf.string: 03 Unknown descriptor: Length: 07 Type: 24 Contents: 01010101000B24 Unknown descriptor: Length: 0B Type: 24 Contents: 02010202100144AC000905

Endpoint descriptor: Endpoint address: 01 Attr.: 0D Max.pkt size: 00C0 Polling interval: 01 Unknown descriptor: Length: 07 Type: 25 Contents: 01010100000904

Interface descriptor: Intf.number: 01 Alt.: 02 Endpoints: 01 Intf. Class: 01 Intf. Subclass: 02 Intf. Protocol: 00 Intf.string: 03 Unknown descriptor: Length: 07 Type: 24 Contents: 01010101000B24 Unknown descriptor: Length: 0B Type: 24 Contents: 02010203180144AC000905

Endpoint descriptor: Endpoint address: 01 Attr.: 0D Max.pkt size: 0120 Polling interval: 01 Unknown descriptor: Length: 07 Type: 25 Contents: 01010100000904

Interface descriptor: Intf.number: 02 Alt.: 00 Endpoints: 00 Intf. Class: 01 Intf. Subclass: 02 Intf. Protocol: 00 Intf.string: 03

Interface descriptor: Intf.number: 02 Alt.: 01 Endpoints: 01 Intf. Class: 01 Intf. Subclass: 02 Intf. Protocol: 00 Intf.string: 03 Unknown descriptor: Length: 07 Type: 24 Contents: 01040101000B24 Unknown descriptor: Length: 0B Type: 24 Contents: 02010202100144AC000905

Endpoint descriptor: Endpoint address: 82 Attr.: 0D Max.pkt size: 00C0 Polling interval: 01 Unknown descriptor: Length: 07 Type: 25 Contents: 01010100000904

Interface descriptor: Intf.number: 02 Alt.: 02 Endpoints: 01 Intf. Class: 01 Intf. Subclass: 02 Intf. Protocol: 00 Intf.string: 03 Unknown descriptor: Length: 07 Type: 24 Contents: 01040101000B24 Unknown descriptor: Length: 0B Type: 24 Contents: 02010203180144AC000905

Endpoint descriptor: Endpoint address: 82 Attr.: 0D Max.pkt size: 0120 Polling interval: 01 Unknown descriptor: Length: 07 Type: 25 Contents: 0100010AE300E7

Addr:1(0.0.1)

With enabled Debug:

Usb.Init=ok MIDI Init Addr:01 VID:1210 PID:001D #Conf:01

Conf:01 Int:00 Alt:00 EPs:00 IntCl:01 IntSubCl:01 No MIDI Device

Conf:01 Int:01 Alt:00 EPs:00 IntCl:01 IntSubCl:02 No MIDI Device

Conf:01 Int:01 Alt:01 EPs:01 IntCl:01 IntSubCl:02 No MIDI Device -EPAddr:01 bmAttr:0D MaxPktSz:C0

Conf:01 Int:01 Alt:02 EPs:01 IntCl:01 IntSubCl:02 No MIDI Device -EPAddr:01 bmAttr:0D MaxPktSz:20

Conf:01 Int:02 Alt:00 EPs:00 IntCl:01 IntSubCl:02 No MIDI Device

Conf:01 Int:02 Alt:01 EPs:01 IntCl:01 IntSubCl:02 No MIDI Device -EPAddr:82 bmAttr:0D MaxPktSz:C0

Conf:01 Int:02 Alt:02 EPs:01 IntCl:01 IntSubCl:02 No MIDI Device -EPAddr:82 bmAttr:0D MaxPktSz:20

NumEP:01

Tell me please, what to do?

YuuichiAkagawa commented 4 years ago

Oh, Your controller's descriptor is too big.

Total length truncated to 256 bytes
Configuration descriptor:
Total length: 0160

The current implementation only supports up to 256 bytes.

Try increasing the buffer size to 384 bytes. https://github.com/YuuichiAkagawa/USBH_MIDI/blob/master/usbh_midi.h#L34

#define DESC_BUFF_SIZE        256

Rifkat6519 commented 4 years ago

Thank you very much! After setting #define DESC_BUFF_SIZE 384. RP-355 started changing presets.

banoydakila commented 3 years ago

Hi, Rifkat6519 can I please see your code to get ideas? I also want to create a controller for my Nuxmg300 but don't know how to send CC message

Rifkat6519 commented 3 years ago

Hi!

My midi footwitch for guitar processor Digitech RP-355.

1. Arduino Leonardo r3(china)
2. USB Host Shield(china)
3. TM1638 "LED&KEY"(8 leds + 8 Keys)(china)
4. 8-buttons

Rifkat.

Rifkat6519 commented 3 years ago

https://www.youtube.com/watch?v=JGsWVKbrNZs&t=134s

banoydakila commented 3 years ago

So my goal is to send cc message from arduino to the device. However this code doesn't work. descriptor is also 256 and I've changed it 384. I'm sending this cc message that I got from midi Ox "B0 3C 01" Can you please help me? skateboard11asd@gmail.com

include

USB Usb; USBH_MIDI Midi(&Usb);

void sendMidi(uint8_t ch, uint8_t ev, uint8_t val) { Usb.Task(); if( Usb.getUsbTaskState() == USB_STATE_RUNNING ){ Serial.println("RUNNING"); uint8_t buf[3]; buf[0] = ch; // 0xB0; buf[1] = ev; // 0x3C; buf[2] = val; // 1; const uint8_t test = Midi.SendData(buf); Serial.println(test); delay(1000);

} }

void setup() { Serial.begin(115200); while (!Serial); if (Usb.Init() == -1) { Serial.println("Usb.Init-Bad!"); while(1); //halt }//if (Usb.Init() == -1... delay( 200 ); }

void loop() { sendMidi(0xb0, 0x3c, 1); }

YuuichiAkagawa commented 3 years ago

@banoydakila Try the develop branch version. https://github.com/YuuichiAkagawa/USBH_MIDI/tree/develop

And example https://gist.github.com/YuuichiAkagawa/4226da674be9fc619b67e6607b797608

banoydakila commented 3 years ago

OMG! this worked like a charm. Thank you very much Sir Yuuichi!

Rifkat6519 commented 3 years ago

HI!

I replaced 2 files v0.6.0 in my sketch and show errors when compiling. In Attach my fixed files( __usbh_midi.cpp and __usbh_midi.h) Compare this files with your last version files(.h, .cpp).

log compile sketch:

libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::Release()' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::USBH_MIDI(USB)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::USBH_MIDI(USB)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::parseConfigDescr(unsigned char, unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::setupDeviceSpecific()' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::Init(unsigned char, unsigned char, bool)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::RecvData(unsigned int, unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::lookupMsgSize(unsigned char, unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::RecvData(unsigned char, bool)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::RecvRawData(unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::countSysExDataSize(unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::SendSysEx(unsigned char, unsigned int, unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::SendData(unsigned char, unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::SendRawData(unsigned int, unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::extractSysExData(unsigned char, unsigned char)' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::epDataOutIndexVSP' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::epDataInIndexVSP' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::epDataOutIndex' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here libraries\USB_Host_Shield_2.0-master\usbh_midi.cpp.o (symbol from plugin): In function USBH_MIDI::Release()': (.text+0x0): multiple definition ofUSBH_MIDI::epDataInIndex' libraries\USB_Host_Shield_2.0-master\MY_usbh_midi.cpp.o (symbol from plugin):(.text+0x0): first defined here collect2.exe: error: ld returned 1 exit status exit status 1 Ошибка компиляции для платы Arduino Leonardo.

Rifkat.

/*

USB-MIDI class driver for USB Host Shield 2.0 Library
Copyright (c) 2012-2018 Yuuichi Akagawa
Idea from LPK25 USB-MIDI to Serial MIDI converter
by Collin Cunningham - makezine.com, narbotic.com
for use with USB Host Shield 2.0 from Circuitsathome.com
https://github.com/felis/USB_Host_Shield_2.0
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see http://www.gnu.org/licenses/

*/

if !defined(_USBH_MIDIH)

define _USBH_MIDIH

//#define DEBUG_USB_HOST

include "Usb.h"

define MIDI_MAX_ENDPOINTS 5 //endpoint 0, bulk_IN(MIDI), bulk_OUT(MIDI), bulk_IN(VSP), bulk_OUT(VSP)

define USB_SUBCLASS_MIDISTREAMING 3

define DESC_BUFF_SIZE 384

define MIDI_EVENT_PACKET_SIZE 64

define MIDI_MAX_SYSEX_SIZE 256

class USBH_MIDI;

class USBH_MIDI : public USBDeviceConfig { protected: static const uint8_t epDataInIndex; // DataIn endpoint index(MIDI) static const uint8_t epDataOutIndex; // DataOUT endpoint index(MIDI) static const uint8_t epDataInIndexVSP; // DataIn endpoint index(Vendor Specific Protocl) static const uint8_t epDataOutIndexVSP; // DataOUT endpoint index(Vendor Specific Protocl)

    /* mandatory members */
    USB      *pUsb;
    uint8_t  bAddress;
    uint8_t  bConfNum;    // configuration number
    uint8_t  bNumEP;      // total number of EP in the configuration
    bool     bPollEnable;
    bool     isMidiFound;
    uint16_t pid, vid;    // ProductID, VendorID
    uint8_t  bTransferTypeMask;
    /* Endpoint data structure */
    EpInfo  epInfo[MIDI_MAX_ENDPOINTS];
    /* MIDI Event packet buffer */
    uint8_t recvBuf[MIDI_EVENT_PACKET_SIZE];
    uint8_t readPtr;

    uint8_t parseConfigDescr(uint8_t addr, uint8_t conf);
    uint16_t countSysExDataSize(uint8_t *dataptr);
    void setupDeviceSpecific();

ifdef DEBUG_USB_HOST

    void PrintEndpointDescriptor( const USB_ENDPOINT_DESCRIPTOR* ep_ptr );

endif

public: USBH_MIDI(USB p); // Misc functions operator bool() { return (pUsb->getUsbTaskState()==USB_STATE_RUNNING); } uint16_t idVendor() { return vid; } uint16_t idProduct() { return pid; } // Methods for recieving and sending data uint8_t RecvData(uint16_t bytes_rcvd, uint8_t dataptr); uint8_t RecvData(uint8_t outBuf, bool isRaw=false); uint8_t RecvRawData(uint8_t outBuf); uint8_t SendData(uint8_t dataptr, uint8_t nCable=0); uint8_t lookupMsgSize(uint8_t midiMsg, uint8_t cin=0); uint8_t SendSysEx(uint8_t dataptr, uint16_t datasize, uint8_t nCable=0); uint8_t extractSysExData(uint8_t p, uint8_t buf); uint8_t SendRawData(uint16_t bytes_send, uint8_t dataptr); // backward compatibility functions inline uint8_t RcvData(uint16_t bytes_rcvd, uint8_t dataptr) { return RecvData(bytes_rcvd, dataptr); }; inline uint8_t RcvData(uint8_t *outBuf) { return RecvData(outBuf); };

    // USBDeviceConfig implementation
    virtual uint8_t Init(uint8_t parent, uint8_t port, bool lowspeed);
    virtual uint8_t Release();
    virtual uint8_t GetAddress() { return bAddress; };

};

endif //_USBH_MIDIH

YuuichiAkagawa commented 3 years ago

Please remove MY_usbh_midi.h and MY_usbh_midi.cpp. Or move it from the libraries directory.

Rifkat6519 commented 3 years ago

Yes you are right. Everything works now. Thank you!

От: Yuuichi Akagawa Отправлено: 2 мая 2021 г. в 11:14 Кому: YuuichiAkagawa/USBH_MIDI Копия: Rifkat6519; Author Тема: Re: [YuuichiAkagawa/USBH_MIDI] Digitech RP-355, why No MIDI Device?(#48)

Please remove MY_usbh_midi.h and MY_usbh_midi.cpp. Or move it from the libraries directory. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

YuuichiAkagawa commented 3 years ago

@banoydakila This issue is about RP-355. Pleas open new discussion or issue.

YuuichiAkagawa commented 3 years ago

Fixed in v0.6.0.
Reference: #72

YuuichiAkagawa / USBH_MIDI

Digitech RP-355, why No MIDI Device? #48

I connect my RP-355 to the PC (usbview.exe) and show(fragment):

=== Start 01

Addr:1(0.0.1)

With enabled Debug:

NumEP:01

include

include

if !defined(_USBH_MIDIH)

define _USBH_MIDIH

include "Usb.h"

define MIDI_MAX_ENDPOINTS 5 //endpoint 0, bulk_IN(MIDI), bulk_OUT(MIDI), bulk_IN(VSP), bulk_OUT(VSP)

define USB_SUBCLASS_MIDISTREAMING 3

define DESC_BUFF_SIZE 384

define MIDI_EVENT_PACKET_SIZE 64

define MIDI_MAX_SYSEX_SIZE 256

ifdef DEBUG_USB_HOST

endif

endif //_USBH_MIDIH