search

YuukanOO / streamy

Use meteor underlying sockets for realtime communications
https://atmospherejs.com/yuukan/streamy
MIT License
104 stars 20 forks source link

Check message_name param for fix used Meteors ones #5

Closed TomFreudenberg closed 9 years ago

TomFreudenberg commented 9 years ago

I have not made a test but this is just as a first reminder.

When looking at meteor source:

https://github.com/meteor/meteor/blob/c0aab1e8d3a5f01b4bedaa1c63dea3fc8f3db9b7/packages/ddp/livedata_connection.js#L223-259

there are some predefined msgs that should not be used as a message_name option when call e.g. 

Streamy.broadcast('error', ... );

So I would suggest, that you validate that option when calling Streamy methods or you just add a static prefix to the messagename like `streamy` to avoid conflicts.

YuukanOO commented 9 years ago

I'll go for the prefix :)

TomFreudenberg commented 9 years ago

Sorry to load you with work ;-)

Please give a short note if I should stop posting!

YuukanOO commented 9 years ago

Sorry for the delay ;)

TomFreudenberg commented 9 years ago

Hey Julien,

thanks for solving that! Works!