search

YuvBindal / pe

0 stars 0 forks source link

Duplicate entries in add for case sensitive strings #1

Open YuvBindal opened 4 months ago

YuvBindal commented 4 months ago

Bug Severity: Medium Bug Type: Feature Flaw

Issue mentioned: The add command does not distinguish between candidates with the exact same information, but the name string is case-sensitive and thus parsed as a different object. As can be seen in the image below:

Screenshot 2024-04-19 at 4.17.59 PM.png

Steps to reproduce: Command 1: add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 $/24.50 t/friends t/owesMoney d/THURSDAY

Command 2: add n/john doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 $/24.50 t/friends t/owesMoney d/THURSDAY

How to fix? Maybe all strings parsed into the prefixed can be lowercased and compared then, if the strings are equal, then the object should not be created.

nus-se-bot commented 4 months ago

Team's Response

image.png

As mentioned in our user guide, names are supposed to be case-sensitive. In addition, in our planned enhancement, we are going to make email and phone number the unique identifier because realistically, we might know 2 individuals with the same name.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]