Open YuvBindal opened 4 months ago
The issue is the missing space between email and the address prefix e/johnT@example.coma/John street, block 123, #01-01
. Adding a space will allow the command to work.
Team chose [response.Rejected
]
Reason for disagreement: [replace this with your explanation]
Issue Mentioned: The add command fails to parse commands when the number prefix is stress tested with over 30+ characters of output. As can be seen in the picture below,
Steps to reproduce: Command: add n/John Tan fromSoC p/987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432 e/johnT@example.coma/John street, block 123, #01-01
Perhaps, a more appropriate response than invalid command format would be to recognise this number as not a valid number and log a message stating that it is not a real number.