YuvBindal / pe

0 stars 0 forks source link

Failure of Add Command under Stress Test for Number #2

Open YuvBindal opened 4 months ago

YuvBindal commented 4 months ago

Issue Mentioned: The add command fails to parse commands when the number prefix is stress tested with over 30+ characters of output. As can be seen in the picture below,

Screenshot 2024-04-19 at 4.27.11 PM.png

Steps to reproduce: Command: add n/John Tan fromSoC p/987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432987654329876543298765432 e/johnT@example.coma/John street, block 123, #01-01

Perhaps, a more appropriate response than invalid command format would be to recognise this number as not a valid number and log a message stating that it is not a real number.

nus-se-bot commented 4 months ago

Team's Response

The issue is the missing space between email and the address prefix e/johnT@example.coma/John street, block 123, #01-01. Adding a space will allow the command to work.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]