Edit command can be used to create duplicate entries based on case sensitivity

[YuvBindal]

Issue Mentioned:

The edit command can be used to rename a person object to the name of a person that already exists. Perhaps, this is due to failure of handling case sensitivity across object comparisons. This can be seen in indices 1 and 4 of the screenshot above.

Steps to fix: Perhaps, the team can look into handling case sensitivity but lower casing the parsed strings before object comparisons.

Regards!

[nus-se-bot]

Team's Response

As mentioned in our user guide, names are case-sensitive, and duplicate names should not be an issue because realistically we can know 2 different people with the same name.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name field is case sensitive

Description

When it comes to names, there should be some case insensitivity. Alex Yeoh and Alex yeoh should be the same person.

Fix

You can consider case insensitivity when parsing the names, i.e. convert everything to lower or upper case when verifying if it exists.

---

_{[original: nus-cs2103-AY2324S2/pe-interim#2300] [original labels: severity.Low type.FeatureFlaw]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

1. Making Phone Number and Email Address Unique

The current FriendFolio system uses a contact’s name as a unique identifier. We are planning to enhance this by switching to using contact’s phone number and email as unique identifiers. This change will prevent multiple individuals from sharing the same email or phone number within the system, while allowing the existence of multiple individuals with the same name.

According to our planned enhancements, we plan to change the unique identifier from name to phone number and email. Making this change will make this a non-issue because we will allow duplicate names (because in real life you can know 2 different people with the exact same name).

In addition, in our UG, we did mention that names are case-sensitive.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I believe the team failed to consider a deeper issue with duplicate entries within their application. By allowing case sensitive duplicates, you are exposing True duplicate entries in the sense that apart from that case sensitive name everything within those two objects is the same, they have the same: 1. Email 2. Phone 3. Address 4. Birthday and more, this is not realistic. Thus, perhaps, the team can look into handling this duplication issue. The reason for this allowance of case sensitivity leading to true duplicates.

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---