Edit commands lets the user input invalid numbers

[YuvBindal]

Issue mentioned: As seen in the picture below, the edit command can be used to edit the number of a person to a number that can not exist.

Steps to reproduce: edit 1 p/1231

Steps to rectify: Perhaps, the team can set a limit of 8-10 valid numbers that must be there for the number input to get accepted! I am aware that the team has set a limit of 3 valid numbers already, but this still allows for the enter of invalid numbers

Regards!

[soc-pe-bot]

Team's Response

There are valid numbers that are 3 digit long, e.g. 999, 995, 911.

1777 is the number for non-emergency ambulance in Singapore.

Users might want to add these as contacts on FriendFolio because it is after all an address book application.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: The original bug reported was that the Edit commands lets the user input invalid numbers such as the example given in the case of 1231.

I am aware that there exists special numbers such as 999, 1777, and more, but these are a very small subset of limited numbers. If the team's intention is to include these small subset of limited numbers they should compile a list of these numbers and allow users to input these specific numbers. The current approach is problematic as it introduces an infinite amount of invalid phone numbers to be allowed as valid input fields for phone numbers within the application.

Moreover, in a usual case, the users of FriendFolio are aimed at common people, they will not have the need to track transactions between themselves and a government agency such as the police. So this issue perhaps exposes a deeper need to reconsider objectives. Rega

---