YuvBindal / pe

0 stars 0 forks source link

Creation of duplicate entries in add with duplicate phone entries, addresses, emails #9

Open YuvBindal opened 4 months ago

YuvBindal commented 4 months ago

Users with the exact same information can be added into the address book even if they have the same name, based on the case sensitivity. Overlooking the case sensitivity of the name, perhaps, the team can try to use an OR statement to factor in duplicate phone, address, email entries as well before deciding if an added object should be added.

Screenshot 2024-04-19 at 5.04.13 PM.png

nus-se-script commented 4 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This feature is one of our planned enhancements in the future.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Edit can lead to creation of duplicated phone, email, and address entries

A user can use the edit command to add duplicated numbers, emails, and addresses of already existing users into the address book. The picture below shows this as the edit command is used to create a duplicated phone number for index 1 and index 4, the same process can be repeated for emails and address entries which should be unique to a user. This mismanagement can result in errors to fetch data in the creation of more advanced features later down the line.

Screenshot 2024-04-19 at 5.07.58 PM.png

Screenshot 2024-04-19 at 5.08.06 PM.png

Regards!


[original: nus-cs2103-AY2324S2/pe-interim#980] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As stated under out planned enhancements.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]