YuvalNirkin / face_swap

End-to-end, automatic face swapping pipeline
GNU General Public License v3.0
827 stars 203 forks source link

Pull request for rotation not working #5

Closed RudyChin closed 7 years ago

RudyChin commented 7 years ago

It turns out that calling abs instead of std::abs refers to the abs in stdlib.h, which is a integer version. So that the if clause will never pass through resulting in no rotation.

Also, I found that in calculating the rotation matrix, the if clause might be short-circuited.

YuvalNirkin commented 7 years ago

You are absolutely right. I'll use std::abs in the other if statement as well.

Thank you!