search

YuvalNirkin / hyperseg

HyperSeg - Official PyTorch Implementation
https://nirkin.com/hyperseg
Creative Commons Zero v1.0 Universal
210 stars 39 forks source link

signal_index is not getting updated #23

Open Dhamodhar-DDR opened 2 years ago

Dhamodhar-DDR commented 2 years ago

The variable signal_index is not getting updated inside the init_signal2weights function in hyperseg_v1_0.py. Hence, it is assigning singal_index = 0 for every meta block in the decoder.

Because of this inside the apply_signal2weights function in each meta block, we will not be able to use all the channels of the input signal channels. Essentially we are using [0:signal_channels] of the whole signal where signal_channels of each block is always less than input signal channels. 

        # Inside apply_signal2weights function
        w = self.signal2weights(s[:, self.signal_index:self.signal_index + self.signal_channels])[:, :self.hyper_params]

So, is the signal_index supposed to be zero for every meta block?

YuvalNirkin commented 2 years ago

signal_index is not suppose to be 0 for each meta block, only the first. This have been tested considerably. Could you please elaborate more on the exact usage?