(New NPM package and version) Make necessary upgrades and changes for Material-UI v5

Yuvaleros / material-ui-dropzone

A Material-UI file upload dropzone

MIT License

485 stars 245 forks source link

(New NPM package and version) Make necessary upgrades and changes for Material-UI v5 #314

Open ShotSkydiver opened 3 years ago

ShotSkydiver commented 3 years ago

Description

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Using in my live website

Test Configuration:

Browser: Safari 15 beta

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

TobyOoO commented 3 years ago

Hope this PR to be merged and get released soon.

ShotSkydiver commented 3 years ago

It should be good to go! I hope it gets merged soon too!

TobyOoO commented 3 years ago

Somehow when I tested it locally with latest material-ui v5, I have to specify default theme and pass theme argument to make it workable.

SoaresMG commented 3 years ago

Any ETA on this?

ShotSkydiver commented 3 years ago

Just updated this to support the just-released material-ui v5 RC-0, and the package naming changes that come along with that (from @material-ui to @mui)

Maxastuart commented 3 years ago

@ShotSkydiver This is great work, incredibly needed, and I'm afraid after poking around that @Yuvaleros (the only person with write-access here) is not likely active on GH any longer. Can you publish a new package to NPM from the fork in your account? (Maybe named material-ui-dropzone-v5?)

ShotSkydiver commented 3 years ago

@ShotSkydiver This is great work, incredibly needed, and I'm afraid after poking around that @Yuvaleros (the only person with write-access here) is not likely active on GH any longer. Can you publish a new package to NPM from the fork in your account? (Maybe named material-ui-dropzone-v5?)

Yeah for sure! I'll do that today, and post the new package link here.

ShotSkydiver commented 3 years ago

New NPM package is live! I ended up scoping it to my NPM username since all unscoped names were seemingly already taken 🙃 New package name to install is @shotskydiver/material-ui-dropzone and the new version will install as v4.0.2! From now on I'll be semi-occasionally maintaining and contributing to this new package, so for anyone wanting to use this package, it now lives (I guess) under the name @shotskydiver/material-ui-dropzone at the repo https://github.com/ShotSkydiver/material-ui-dropzone! Contributions are extremely welcome!