Support MUI v5 (and upgrade to React v17).

Yuvaleros / material-ui-dropzone

A Material-UI file upload dropzone

MIT License

483 stars 248 forks source link

Support MUI v5 (and upgrade to React v17). #327

Closed sah closed 2 years ago

sah commented 2 years ago

Description

Support MUI v5 (and upgrade to React v17, as required by MUI). This just required updating package.json and changing package imports.

Fixes #305

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

Manually tested, and I've been using this on a production website for several months.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

TillerBurr commented 2 years ago

Should @mui/styles be added to package.json? Otherwise, it requires a separate install.

sah commented 2 years ago

Should @mui/styles be added to package.json? Otherwise, it requires a separate install.

I agree it should. Added.

LucasBassetti commented 2 years ago

Hey! Any predictions to merging this? It will be good to use this package with v5

amireallyadev commented 2 years ago

I am waiting for this too. I can not migrate to MUI 5 due to this.

LucasBassetti commented 2 years ago

@Yuvaleros could you please merge this and create a new release?

TillerBurr commented 2 years ago

@Yuvaleros could you please merge this and create a new release?

There is a fork that has merged equivalent changes and fixed an issue with the snackbar. It's published on npm as react-mui-dropzone

puriasafarihesari commented 2 years ago

@baurt, I have been trying out npm package you're referring to for the past couple of days and I'm still unable to override the styles with the various namespaces such as MuiDropezoneArea. Do you have a working example of that by any chance?

TillerBurr commented 2 years ago

@puriasafarihesari No. I haven't tried overriding the styles. I use the package and styles as is.

cannontechnology commented 2 years ago

@Yuvaleros can you please merge some of these pull requests or add someone else as a maintainer?

LucasBassetti commented 2 years ago

@Yuvaleros thanks! 🤩 Will you publish a new npm release with v5 support?

cannontechnology commented 2 years ago

Thanks, @Yuvaleros! Can you publish a new npm release?