Yuvaraj0702 / pe

0 stars 0 forks source link

Improper exception raised when adding houses #2

Open Yuvaraj0702 opened 1 year ago

Yuvaraj0702 commented 1 year ago

Description: When trying to add a new property listing the property is successfully added but it is accompanied by an error message saying Could not save data to file: java.nio.file.AccessDeniedException: C:\WINDOWS\system32\data Steps to reproduce:

  1. Open Condonery.jar
  2. Type in command add -p n/Pinnacle@Duxton a/Cantonment Rd, #1G, 085301 p/100,000 h/CONDO t/luxury
  3. Press enter.

Image showing error: image.png

Reasons for reporting bug:

  1. This exception should not be thrown at all.
  2. Even if it is thrown it should be handled gracefully.
nus-pe-script commented 1 year ago

Team's Response

Jar file placed in a folder where user has no write permissions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: As the dev team realizes this may be due to the fact that the file was in a folder with no write permission. If the team is well aware of this error they are able to replicate it as they have stated how to do so as well. The team could place the file in such a folder and easily replicate this error. Hence, there is no issue with reproducing the error. And since the team is aware of such an error the exception thrown must be handled properly with a better error message. This situation is highly unlikely to happen but it happened even when the tester downloaded the file multiple times in different folders. It was by sheer luck that the product worked on the tester's laptop. The assumed rarity of the error is why it was given a very low rating. Else it would have been a medium or a high. Thus, the tester disagrees with the dev team respectfully.