Yuzmeister / fbpwn

Automatically exported from code.google.com/p/fbpwn
0 stars 0 forks source link

Cannot get friends list from URLs without ID (but a user alias) #41

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Use a URL like http://www.facebook.com/daujones42 instead of 
http://www.facebook.com/profile.php?id=100002466728554

What is the expected output? What do you see instead?
Either the friend list is empty (in the case above), or (when following links) 
wrongly interprets the URL parameter "refid=5" as profile id 5.
Expected output: The correct list of friends :-)

What version of the product are you using? On what operating system?
Both the latest stable (0.1.7) and svn r72 suffer from that problem.

Original issue reported on code.google.com by stefan.s...@gmail.com on 28 Jan 2012 at 8:42

GoogleCodeExporter commented 8 years ago
Ok, I've made a patch fixing the problem. It extracts the user id from the 
profile in case the user id is not found in the url.

Original comment by stefan.s...@gmail.com on 28 Jan 2012 at 2:15

Attachments:

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r73.

Original comment by HusseinElMotayam@gmail.com on 28 Jan 2012 at 6:19

GoogleCodeExporter commented 8 years ago
Many thanks for reporting the issue and for the patch :)

I applied your patch in r73. The patch seems to be working flawlessly, however 
it is quite slow to fetch each account's friend page (took me about 3 minutes 
to get a list of 100 friends).

We are currently working on version 0.2, we'll try to optimize it a little bit.

Thanks again :)

Original comment by HusseinElMotayam@gmail.com on 28 Jan 2012 at 6:21

GoogleCodeExporter commented 8 years ago
Of course, network access increases latency. But at first glance, I saw no 
other way.
Suggestions for future development:
- Do lazy information fetching (only fetch profile when required, not in 
constructor)
- Use loaded profile to complete other data (e.g. name)

Original comment by stefan.s...@gmail.com on 29 Jan 2012 at 12:18