search

YuzuTen / membrane_s3_plugin

Membrane framework plugin to support S3 sources/destinations
Apache License 2.0
5 stars 3 forks source link

Update to newer version of `membrane_core` #28

Open samrat opened 3 months ago

samrat commented 3 months ago

Hello 👋

Looks like this plugin isn't compatible with the latest version of Membrane:

Because every version of membrane_s3_plugin depends on membrane_core ~> 0.10 and your app depends on membrane_core ~> 1.1, no version of membrane_s3_plugin is allowed.
So, because your app depends on membrane_s3_plugin ~> 0.1, version solving failed.
** (Mix) Hex dependency resolution failed

Do you plan on updating it?

JasonTrue commented 3 months ago

Hello 👋

Looks like this plugin isn't compatible with the latest version of Membrane:

Because every version of membrane_s3_plugin depends on membrane_core ~> 0.10 and your app depends on membrane_core ~> 1.1, no version of membrane_s3_plugin is allowed.
So, because your app depends on membrane_s3_plugin ~> 0.1, version solving failed.
** (Mix) Hex dependency resolution failed

Do you plan on updating it?

Hi @samrat, I'm currently not actively using Membrane framework (the project that used it was spun down when my previous employer's client chose a different audio communications provider that didn't have hooks that would enable a service like that).

The last time I tried to update it, some really aggressive design changes in Membrane's design made it non-trivial and it wasn't a high business priority for my team. I would be happy to take a PR to make it work with more recent versions of Membrane, and I would be reasonably motivated to update it myself if there was some funding behind the request.

samrat commented 3 months ago

I got a sink implementation working here: https://samrat.me/p/4e716b73-ba4e-4a58-9740-6bfbfba6d899/

I'll try to work it into a PR.