YvanDotet / query_deluxe

12 stars 19 forks source link

Updates add all users of group_erp_manager #31

Closed bertstomphorst closed 1 year ago

bertstomphorst commented 1 year ago

We love query_deluxe, but experience an issue when de module is updated: all members of base.group_erp_manager are added again to query_deluxe.group_query_deluxe. We've a user who is allowed to edit access-rights (because of creating new users), but not should have access to query_deluxe. Although this user could enable it for himself, that's no problem. Now it's confusing that 'out of the blue' there's an additional icon on the main menu.

Can you please mark those security-data as no-update (only on initial install of the module)?

YvanDotet commented 1 year ago

Dear Mr Stomphorst, Thank you for your comment.

As I understand, you want to mark as 'no-update' the adding moment where the user from group 'group_erp_manager' is added to the "query deluxe" group ?

By doing this, this will add the user only once, and then if you update de module query deluxe after modifications, it will not put him again on this group.

(Sorry for the delay of the answer) .

Sincerely. Yvan.

@bertstomphorst

bertstomphorst commented 1 year ago

Hi Yvan, Yes, that's what I should expect. Thank you, Bert

YvanDotet commented 1 year ago

Ok it is a good idea because the security for this module is important with the possibility of doing sql request within the interface.

Thanks for you contribution, I will add it.

I have just one another question : did you test this module on odoo sh ? Which version did you download ?

Thank you and have a good day. Sincerely, Yvan.

bertstomphorst commented 1 year ago

Hi Yvan, Thanx! Yes, I'm using it on odoo.sh, linked as submodule, current version 16.0.1.0.5

YvanDotet commented 1 year ago

Ok thanks. I ask this because someone else have telling me about an error on odoo sh, but if it's work it's ok. https://github.com/YvanDotet/query_deluxe/issues/29

The new version with the modification is actually available "16.0.1.0.6". https://apps.odoo.com/apps/modules/16.0/query_deluxe/

bertstomphorst commented 1 year ago

Ok, I'm on Odoo 15 not on 16.

I've got the update today and works fine, thanx!