Strange plant bug

[pettrs]

the strange appears to be flashing in and out of hiding https://user-images.githubusercontent.com/75093127/213285290-0f7c0f8f-bb90-49e2-b468-d1d856642bf3.mp4

[YvesW]

I've changed around some of the code so it might be fixed in my latest dev build, but I've had multiple strange plants and have not been able to reproduce this. It looks like it happens while the plant is growing? It should still have the same NpcId though which means that

if (npcId == NpcID.STRANGE_PLANT) {
            return hideAllStrangePlant;
        }

should hide it though. Will keep this open and will keep an eye out for it.

[pettrs]

Still experiencing this same bug but with other random events

https://user-images.githubusercontent.com/75093127/213760798-87f607e2-998f-43fd-945c-e15df2b6b8ad.mp4

https://user-images.githubusercontent.com/75093127/213760864-ea2aa587-5e8e-44fe-aa82-46e4895df245.mp4

[YvesW]

The code hasn't changed, so makes sense it hasn't changed (PR waiting for approval). However, I've never had this bug myself. Are you playing on the official runelite client, or some shady fork?

[pettrs]

I'm playing the official runelite client through the Jagex launcher. I've only experienced though twice though, both of which I showed. so it appears to be working with the other random events

[pettrs]

nevermind https://user-images.githubusercontent.com/75093127/213825327-120381b6-9f44-4369-832f-984dd5697ad3.mp4

[YvesW]

Might be related to you being in combat; I'll have to check in the latest devbuild and also in combat. When I'm in combat (raids), randoms usually can't spawn. I'll let you know when the PR gets merged and then you can check again.

[YvesW]

@pettrs Could you upload some screenshots? That might confirm my hypothesis (race-y behaviour).

1. A screenshot of the settings of Random Event Hider
2. A screenschot of the settings of core (default) Entity Hider Thanks in advance!

[pettrs]

I have entity hider disabled, and it's still happening

[pettrs]

alright, I think I've been able to source down the issue. I noticed when I hide attackers (also what random events go under) it seems like when the attack isn't attacking you, like a random event, it flickers.

https://user-images.githubusercontent.com/75093127/213931332-14bdd374-37c4-49a5-ad60-30fe58dc855a.mp4

now I'm seeing players flick too so I'm not entirely sure what's going on. might just be an issue with me

https://user-images.githubusercontent.com/75093127/213931266-9f86cc22-230b-4ce9-b99f-8cbeabe29b1a.mp4

[YvesW]

The client does indeed not know the difference between "combat" and "interaction", but it's really weird that you also see the attackers and even the 2D elements of players flicker. 3rd party plugins only have the ability to use the shouldDraw function from the RL API, so I'm afraid that's borked for you for some reason, e.g. different plugin interfering(?), bad implementation if you were on a fork etc. If you can get the flickering consistently with entity hider enabled (e.g. Npcs, 2D elements of players), I'd suggest trying safe mode for a while and seeing if it persists. From RL discord:

Launch RuneLite in safe mode using the following command: "%localappdata%\runelite\runelite.exe" --clientargs --safe-mode

This temporarily disables all 3rd party plugins which will allow you to confirm the issue is caused by the plugin and isn't a core RuneLite issue.

If the issue is caused by a 3rd party plugin, you should isolate which plugin it is and then uninstall the plugin.

I'm afraid that with the current info, it looks like it's not something I can fix (underlying problem, not a problem of this specific plugin), at least not while I haven't been able to recreate it myself (my entity hider also works perfectly). I'll let you know when the latest update has been merged; maybe that that'll fix it but I doubt it. I'll also try to keep an eye out myself to see if I can recreate this.

[ZeiZeiii]

Im currently having this same issue with different random events as well.

[YvesW]

Im currently having this same issue with different random events as well.

@ZeiZeiii Do you see NPCs briefly visible (e.g. 1 tick) when they spawn? Cause I've fixed that in the latest dev build (still waiting for RL maintainers to merge it). Or do you see NPCs flashing continuously like Pettrs?

If it's the latter, can you reliably reproduce it? If yes, does it also happen to other stuff from the default Entity Hider core plugin like Pettrs showed earlier?

[ZeiZeiii]

@YvesW same kind of flickering like Pettrs has, with multiple different events. Core Entity Hider works as intended.

[YvesW]

@YvesW same kind of flickering like Pettrs has, with multiple different events. Core Entity Hider works as intended.

Is it only in combat, or also out of combat? I'll also give you a ping while the latest dev build has been merged, so you can try it out ans see if it still happens.

[ZeiZeiii]

In both. While standing still and on move as well. Thank you!

Jan 31, 2023, 19:08 by @.***:

@YvesW https://github.com/YvesW>> same kind of flickering like Pettrs has, with multiple different events. Core Entity Hider works as intended.

Is it only in combat, or also out of combat? I'll also give you a ping while the latest dev build has been merged, so you can try it out ans see if it still happens.

— Reply to this email directly, > view it on GitHub https://github.com/YvesW/random-event-hider/issues/3#issuecomment-1410756669> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A5NSN2PZ6FATFVGYA2WWNVTWVFBJHANCNFSM6AAAAAAT7QNMIM> . You are receiving this because you were mentioned.> Message ID: > <YvesW/random-event-hider/issues/3/1410756669> @> github> .> com>

[YvesW]

@pettrs @ZeiZeiii The update has been merged; restart your client for it to take effect. As a sidenote, I tried to replicate it while afking some vyrewatch sentinels earlier and I could not get the random events to flicker at all.

[ZeiZeiii]

Seems to be working accordingly now. Thank you sir! :)

Feb 3, 2023, 16:47 by @.***:

@pettrs https://github.com/pettrs> > @ZeiZeiii https://github.com/ZeiZeiii> The update has been merged; restart your client for it to take effect. As a sidenote, I tried to replicate it while afking some vyrewatch sentinels earlier and I could not get the random events to flicker at all.

— Reply to this email directly, > view it on GitHub https://github.com/YvesW/random-event-hider/issues/3#issuecomment-1415976939> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/A5NSN2NXWE6VI3FNAE5TPMDWVULB3ANCNFSM6AAAAAAT7QNMIM> . You are receiving this because you were mentioned.> Message ID: > <YvesW/random-event-hider/issues/3/1415976939> @> github> .> com>