search

YyzHarry / imbalanced-regression

[ICML 2021, Long Talk] Delving into Deep Imbalanced Regression
http://dir.csail.mit.edu
MIT License
819 stars 129 forks source link

move get_transform to __init__ #40

Closed LiuNingtao closed 11 months ago

LiuNingtao commented 11 months ago

Hi,

Thank you for your great work.

A little suggestion, probably you can move the data transforms to the init of the dataset class instead of invoking the _gettransform each time get data.

I think this would be better to improve the speed of preparing the data and hope this is helpful for you.

Thank you.

Ningtao

School of AI, Xidian University, China Robarts Research Institute, Western University, Canada

YyzHarry commented 11 months ago

Hi Ningtao, thanks for your interest in our work. Your suggestion sounds interesting, but due to limited bandwidth, we will not be looking into it for now. We welcome contributions, so if you're able to test and validate the improvements, please consider submitting a pull request.