Meeting response instance ID is not passed to backend - Githubissues

Z-Hub / Z-Push

Home of Z-Push

https://z-push.org

GNU Affero General Public License v3.0

94 stars 44 forks source link

Meeting response instance ID is not passed to backend #111

Open mschering opened 1 month ago

mschering commented 1 month ago

Describe the bug In this line the instanceid is taken from the request:

https://github.com/Z-Hub/Z-Push/blob/446e0466d7af1cb97a9fc945ffa2565d55f9b719/src/lib/request/meetingresponse.php#L65

But it's never passed to the backend:

https://github.com/Z-Hub/Z-Push/blob/446e0466d7af1cb97a9fc945ffa2565d55f9b719/src/lib/request/meetingresponse.php#L97

Making it impossible to handle a response for an instance of a recurring instance.

To Reproduce Approve an instance and the whole series is updated.

Expected behavior Only the instance should be updated

Logs

Server (please complete the following information):

OS: iOS
PHP Version: 8.2
Backend for: Group-Office
and Version: 2.7.3

matidau commented 1 month ago

@mschering thanks for raising this, it might be a breaking change so I'll need to leave this for another version and mark it as an "Enhancement" even though it is a bug so I can keep track if it.