search

Z-Hub / Z-Push

Home of Z-Push
https://z-push.org
GNU Affero General Public License v3.0
97 stars 47 forks source link

Php82 fixes #66

Open mschering opened 6 months ago

mschering commented 6 months ago

Released under the GNU Affero General Public License (AGPL), version 3

Some PHP 8.2 compatibility fixes.

matidau commented 3 months ago

@mschering Thanks for the PR, sorry it's taken me so long to get to it.

z-push-top in develop isn't causing me any PHP 8.2 errors, for the most part I think your changes might be implementation dependent with the backend your using. Could be wrong let me know your thoughts.

For the serialization, this is an issue, thank you for raising it. Your commit is causing an error with the state files. Example from the log:

01/08/2024 15:56:52 [1229260] [WARN] [mail@xxx.id.au] /usr/local/lib/z-push/lib/utils/utils.php:1466 Erroneous data format for unserializing 'StateObject' (2)
01/08/2024 15:56:52 [1229260] [WARN] [mail@xxx.id.au] /usr/local/lib/z-push/lib/utils/utils.php:1466 unserialize(): Error at offset 22 of 2493 bytes (8)
01/08/2024 15:56:52 [1229260] [WARN] [mail@xxx.id.au] FileStateMachine->GetState(): Failed on unserializing filename '/var/lib/z-push/9/1/androidc1307007219-devicedata' - attempt: 1
01/08/2024 15:56:52 [1229260] [FATAL] [mail@xxx.id.au] FileStateMachine->GetState():Unable to unserialize filename '/var/lib/z-push/9/1/androidc1307007219-devicedata' after 1 attempts

Cheers, Mat