search

Z-app / zmote

BSD 2-Clause "Simplified" License
0 stars 1 forks source link

Discovery.java, find() #2

Closed leoja139 closed 11 years ago

leoja139 commented 12 years ago

The find() function only works when connected to the local network.

chrte commented 12 years ago

Well, the find() function can only work if the phone is connected to the local network. Although we could add a pop up window if you are not connected via WiFi, asking the user if the users wants to connect to the network. I have labeled this as an enhancement, we can fix this later, but we should not spend to much time on this issue yet.

tehvicke commented 12 years ago

Yes it's an enhancement. I'll do the findSTB function next sunday and if time allows it a popup if the wlan isnt found.

If noone else does it today that is ^^. Hope the hackaton goes well.

crholm commented 12 years ago

No. you are misunderstanding the bug. The se.z_app.stb.api.zenterio.Discovery.java should find all boxes at a specified sub-net. Not only the one you are connected to. The GUI specifies the subnet to search, Discovery.java shall not. It shall only search the subnet. We can discuss it next weekend if it is unclear

tehvicke commented 12 years ago

The enhancement im talking about should be in the gui and tells the user if hes not connected to any local network.

crholm commented 12 years ago

Yup, never the less is the discovery.java not working properly.

tehvicke commented 12 years ago

Ah ok so the problem lies there. It's because I changed the function a bit (made it gui --> STBDiscovery.java --> Discovery.java, but wasn't able to test it so it's probably just a minor bug. Ill get it to work next weekend, am kinda stuffed right now. If it's needed right now someone else can probably troubleshoot it as it's just a couple of rows added.

GUI calls STBDiscovery that in turns calls zenterio.Discovery.java, that returns an STB[] to STBDiscovery that returns that STB[] to GUI.

crholm commented 12 years ago

Well done. That is exactly how its is suppose to work.

chrte commented 11 years ago

With the new discovery functions, this problem should have been solved? Right? Can we close the issue?

tehvicke commented 11 years ago

The function works great but the STB selection view doesnt tell the user if hes not connected to a network. The function just doesnt return any boxes, which is correct. So according to me this issue can be closed.

Might raise an issue for that in select STB view instead.

chrte commented 11 years ago

Nice, I close this issue now.