Z0rdak / Yet-Another-World-Protector

Yet Another World Protector is a server-side protection mod which allows you to protect your creations against various different events/actions of players, mobs and the environment. It was inspired by the forge mod WorldProtector and the WorldGuard plugin.
https://www.curseforge.com/minecraft/mc-mods/yawp
GNU Affero General Public License v3.0
19 stars 8 forks source link

TNT explosion server crash #106

Closed WisdomShrimp closed 2 months ago

WisdomShrimp commented 3 months ago

TNT exploding in a local region (igniting tnt above the local region area or using a slime block to move an ignited tnt into the local region) causes the server to crash.

Fabric 0.15.7 Minecraft 1.20.4 YAWP 0.0.2.9-beta3

Z0rdak commented 3 months ago

Hi thanks for the report and the version info.

Can you please additionally provide the region definition of the Local Region involved?

Either as file, link or code block

Edit: You may as well join the discord server and reach out to me there.

Thanks

Z3R0TR0N commented 2 months ago

Hi,

I can confirm our server experiences the same problem. It specifically occurs when a region is protected with the flag: "Ignite-explosives", then TNT is then ignited within the protected region. When the TNT swells to explode, the server freezes and crashes, giving a Stack Overflow error from a ticking entity. Same versions as above: Minecraft 1.20.4, YAWP 0.0.2.9-Beta3, The latest Fabric edition for Minecraft 1.20.4.

EDIT: We noticed an updated version from a few days ago with the same version number as ours. We'll try to install this version to see if it's been patched.

Z0rdak commented 2 months ago

Thank you for confirming this issue.

I'll take a look at it asap.

Z0rdak commented 2 months ago

I found the issue. I might (I definitely have!) introduced a endless-recursion when porting the new version. My bad.

I will publish a fixed version later this day.

Edit: I've found a bigger underlying issue that affects all fabric versions. I already solved the isse and will publish the fixed versions soon.

Saxostevesaxo commented 2 months ago

Hiya, im getting this issue too on 1.20.4 with end crystals too. i dont have the flags applied anywhere either thanks

Z0rdak commented 2 months ago

Thanks for the additional insight @Saxostevesaxo.

Fixing the issue on all fabric versions currently.

Z0rdak commented 2 months ago

Fixed in 0.0.2.9-beta4. Available for Fabric 1.20.1 and 1.20.4.

Saxostevesaxo commented 2 months ago

can confirm its fixed! thankyou!