search

Z3NTL3 / ProxyBeast

ProxyBeast is a powerful, complete and free proxy checker with zero dependency and advanced capabilities.
https://proxy.pix4.dev/
GNU General Public License v3.0
23 stars 10 forks source link

Some fixes #7

Closed ghost closed 1 year ago

ghost commented 1 year ago

Changes

  1. added -threads option
  2. renamed many things for better understanding
  3. made a better showcase video
  4. updated README
Z3NTL3 commented 1 year ago

Request feedback

Hello!

Thanks for making out an pull request. However after a review we marked this pull request as unnecessary and inefficient.

For example: you have changed theswitch statement which was used to check input with an very long if condition. It is a bad practice to use a if statement on long conditions instead of switch. A switch statement uses less memory in the situation.

We also see that you rename variable names which is also not needed. Everything is already self-explaining.

You have also accomplished doing inefficient functionalities. Like adding arguments to a function, as these parameter you defined were already drawn through the globals.

So basically we won't be pulling this fork however thanks for your efforts. I appreciated your interest in ProxyBeast <3

Additional information

Future enhancement deadlines