search

Z3Prover / FirewallChecker

A self-contained firewall checker
MIT License
101 stars 13 forks source link

Firewall rules in Italian language #7

Open filippobottega opened 4 years ago

filippobottega commented 4 years ago

Hello, I'm testing FirewallChecker but I'm using an italian version of Windows 10 and I get an italian translation of firewall rules when I export rules using Windows Defender Firewall. In the output file I can see "Qualsiasi" for "Any" and so on.

How can I export rules in english language? Do I have to change all strings in the code to make an italian version of FirewallChecker?

Best regards, Filippo.

ahelwer commented 4 years ago

Could you provide a sample firewall rule file? The code really cares about these header values (as seen in the example rule files:

Name Enabled Action Local Port Remote Address Remote Port Protocol

So if you do an in-place translation your firewall rule file headers to these then it should work.

If you alternatively want to keep using the Italian language headers, you can compile your own version of the Firewall Checker while switching out these header constants for their Italian counterparts.

filippobottega commented 4 years ago

I think that FirewallChecker has to be independent from OS language. Could you try to check if WindowsFirewallHelper may help you to read firewall rules without using the standard export/import csv file?

ahelwer commented 4 years ago

Hmmm... I'm leaning toward adding a parameter which is a path to a JSON file defining the language-specific overrides for the english firewall file headers. That library requires you execute the firewall checker on the same machine on which you're analyzing it... which might actually be helpful for the FirewallQuery app. I'd say if the WindowsFirewallHelper library enables querying the values of the macros (from your issue #8) then I would consider integrating it. Will take a look.

filippobottega commented 4 years ago

If you like to let FirewallChecker unchanged, you can develop a console application, named FirewallReader for example, using WindowsFirewallHelper only to export Firewall rules in english CSV files. You may use FirewallReader to convert macros into port and addresses ranges.

ahelwer commented 3 years ago

Hi Filippo, I set my computer display language to Italian but I cannot get my firewall rules to export including Italian words as described. Any chance you could send me a copy of your exported firewall rules so I can see what differences exist?