Error parsing Internet and Intranet Predefined set of computers

Z3Prover / FirewallChecker

A self-contained firewall checker

MIT License

101 stars 14 forks source link

Error parsing Internet and Intranet Predefined set of computers #8

Open filippobottega opened 5 years ago

filippobottega commented 5 years ago

Hello, in file WindowsFirewallRuleParser.cs the method private static AddressSet ParseAddressSet(string text) raises an exception in case of Internet and Intranet Predefined set of computers. Please see Windows Firewall. Internet and Intranet Predefined set of computers.. I suppose to be a bug.

Regards, Filippo.

ahelwer commented 5 years ago

This is similar to port macros, which are currently not supported; you can fix this by replacing the macros in your firewall input file with a comma-delimited set of addresses corresponding to the Internet macro. The code should probably handle this more gracefully, though (I didn't know there were macros for addresses as well as ports).

filippobottega commented 5 years ago

Yes, I agree with you, there are macros for addresses and I think that FirewallChecker has to take care about macro conversion to the current values. The problem is that there are a lot of rules that use macros and without macro conversion FirewallChecker may be not so useful.

ahelwer commented 5 years ago

What are you using firewall checker for?

filippobottega commented 5 years ago

I need a tool to understand which rules are allowing inbound traffic. For example I have had the problem to understand why my PC was able to response to ping requests.