Allow string IDs - Githubissues

Z3d0X / filament-fabricator

Block-Based Page Builder Skeleton for your Filament Apps

https://filamentphp.com/plugins/fabricator

MIT License

269 stars 52 forks source link

Allow string IDs #158

Closed rojtjo closed 4 months ago

rojtjo commented 5 months ago

I'm currently integrating this package into an existing project that already has a pages table with UUIDs. While working on migrating the data I ran into a TypeError when opening the edit page because the UUID is passed as a string, but it expects an integer.

Due to already existing relations on the UUIDs I'd prefer to keep them as they are.

These changes allow the id and parent_id fields to be a string.

what-the-diff[bot] commented 5 months ago

PR Summary

Update in FilamentFabricatorManager.php The method for getting a page's URL from its unique identifier (ID) has been improved in this file. Now, in addition to numbers, it can also accept text as input for the unique identifier, offering greater flexibility.
Changes to Page.php file The annotations, notes that help explain how to use certain code parts, for two properties - id and parent_id - inside the Page.php file have been updated. They can now be either a number or a text string. This amendment highlights an adjustment in how we identify and classify pages and their categorization structure.

Z3d0X commented 5 months ago

Is this the only change needed for this?

rojtjo commented 4 months ago

Besides using a custom model with the HasUuids trait and customizing the migrations, yes!