search

Z3d0X / filament-fabricator

Block-Based Page Builder Skeleton for your Filament Apps
https://filamentphp.com/plugins/fabricator
MIT License
252 stars 48 forks source link

Deleted Block will make a page unrenderable #39

Closed ijpatricio closed 1 year ago

ijpatricio commented 1 year ago

Hello @Z3d0X

First, I want to thank you again for such a beautiful implementation of blocks in Filament!

So now, I ran into a problem: I deleted a block after a given page was saved into the database. I expected that the rendering mechanism ignored the JSON's non-existing blocks, but an exception was thrown.

Is this the desired behavior?

Below is a screenshot and the video link at the timestamp where it happened. It's in Portuguese, but without sound, you realize what happened. After undeleting the block files, it went back to normal

https://youtu.be/4PGkwDa3B4s?t=4643

image

Z3d0X commented 1 year ago

Hi sorry you ran into this issue. This is a bug yes, deleted blocks should be ignored.

I will work out a fix shortly.

Thank you for bringing this to my attention.

PS: I love the content you made featuring this plugin

ijpatricio commented 1 year ago

Oh, that's nothing. No worries!

PS: Thanks! And soon I'll make it in English also, so it can be viewed by a larger audience. Better to do it on V3, as it should come out in the next month(ish)?!?? 😄