Z3nner / lancer-weapon-fx

Visual and Sound Effects for use primarily with the Lancer TTRPG system on Foundry.
5 stars 6 forks source link

Fx Pass Feedback 2 #28

Closed cirrahn closed 9 months ago

cirrahn commented 9 months ago
cirrahn commented 9 months ago

I am not sure if my "improvements" are the best either, I could not find a good writeup of what the algorithm is supposed to do in these edge cases so I went with what suited the missiles! There is probably a good implementation in the wild to borrow from but I did not spend the time to search. But it works for now and there are tests to make sure it does not regress.

The reorganization has some downsides (more files so maybe more latency in the load, functions removed from the API but can be added back later) but it enables easy testing and a simple bundler could be used later if file count becomes a problem