Closed cirrahn closed 3 months ago
I like the idea. I think a module setting to enable/disable the effect-guessing is a must. I'd be fine with it being on by default. I think the assignments listed are good ones, I can't think of any changes I'd make to them.
Agreed with having it as a setting, but yeah, having it on by default seems good. Effects look great to me! Thanks for doing this!
PR updated. New setting added:
If we do not have a defined effect for a weapon, allow the module to pick one which should be appropriate. This helps to bridge the gap for homebrew items in the absence of a customization option.
All credit to @dodgepong for the idea and algorithm.
@dodgepong's algo:
Type: Melee
Type: CQB
Type: Cannon
Type: Launcher
Type: Nexus
Type: Rifle
Preview (extra choppy as I removed a third of the frames to fit in GitHub's size limit!)
h2.webm
Some questions: