Z3nner / lancer-weapon-fx

Visual and Sound Effects for use primarily with the Lancer TTRPG system on Foundry.
5 stars 6 forks source link

Module Won't Load #7

Closed AmbushXXVI closed 1 year ago

AmbushXXVI commented 2 years ago

When I attempt to enable the Lancer Weapon Fx module, I get an error that JB2A_dnd5e is not enabled. I've got the Patreon Complete Collection installed and enabled on this world. Does this not work for some reason with the paid Patreon content?

Gazkhan commented 2 years ago

@dodgepong I've had a quick look at this and since you're using the Sequencer database paths in the macros, it will be compatible with both the free pack and the Patreon pack. So, instead of a hard dependency from the module.json, you could maybe add something like this to your main script WeaponFX.js ?

Hooks.on('ready', () => {
    if (!game.modules.get('jb2a_patreon')?.active && !game.modules.get('JB2A_DnD5e')?.active){
        ui.notifications.error("You need either the Free or the Patreon version of JB2A for this module to work properly");
    }
})

It's just an example though, I'm sure you can do much better than me ! 😅

dodgepong commented 2 years ago

I'm not the maintainer of the module but I think Zenn is pretty open to pull requests.

Gazkhan commented 2 years ago

Oh ok thanks. I've gone ahead and created a PR. Take it or leave it though, no hard feelings 😆