specialist search refactor

ZAB909 / ChapterMaster

13 stars 21 forks source link

specialist search refactor #194

Closed OH296 closed 10 months ago

OH296 commented 10 months ago

creates specialised methods for searching for different role sets (e.g pykers or tech based roles) rather than hardcoding if statements.
improves existing is_specialist method
for 8.3.0

OH296 commented 10 months ago

Transfer button is clickable, but only works when the marine also has Promote button enabled.

Also after promoting a marine to HQ Apothecary, he could still be promoted there again.

both behaviours pre-existed this pr, and the transfer behaviour is intended unless "Allow astartes transfer" is checked in company settings.

Will create an issue for solving promotion as the system is in need of an overhaul