ZAB909 / ChapterMaster

13 stars 21 forks source link

fully automate squads #195

Closed OH296 closed 10 months ago

OH296 commented 10 months ago

in theory uses all existing infrastructure so if tests fine can be either 8.2.1 or 8.3.0 or even an 8.2.2

GalacticChimp commented 10 months ago

Better to assign to 8.2.2. or 8.3.0, too risky to do any larger changes before a bugfix release

OH296 commented 10 months ago

Better to assign to 8.2.2. or 8.3.0, too risky to do any larger changes before a bugfix release

probably look at stocking some minor stuff for a potential 8.2.2 then come December we can take a view on a handful of smaller tweaks or a big release

OH296 commented 10 months ago

includes #194 and #193

ZAB909 commented 10 months ago

What space monkey said

GalacticChimp commented 10 months ago

fixed Build issue from #193, but still cannot transfer marines who have Promote disabled, like in #194

OH296 commented 10 months ago

fixed Build issue from #193, but still cannot transfer marines who have Promote disabled, like in #194

build issue was never an issue, and transfer issue is not an issue as per comments in #194 however will alter both in their own prs to try and ship with 8.2.3 as they represent stand alone changes that should be made

GalacticChimp commented 10 months ago

please merge newest main since I merged the 2 earlier PRs.

Also, are squads supposed to be of various sizes?

image

also saw a squad of size 1, just with Chaplain, in Company I

OH296 commented 10 months ago

please merge newest main since I merged the 2 earlier PRs.

Also, are squads supposed to be of various sizes?

image

also saw a squad of size 1, just with Chaplain, in Company I

the scouts are supposed to be like that as thanks to mystic we have two types of scout squads with sharpshooter or sniper squads having a max of 5 units while standard scout squads have a max of 10

and the chaplain is not in any squad because command squads can only take one chaplain and there is no other squad he has the correct role for so any ancillary specialists that don't fit in a squad moved into the company will just get clumped together with him.

basically squads can be any size as long as they fit within the parameters of the squad templates

OH296 commented 10 months ago

@GalacticChimp merged with main

OH296 commented 10 months ago

please check my comments

made a special method should be less bulky

best way to test all this is to play as salamanders or lamentors and move random groups of units into an empty company and you should see either the whole squads being moved or new squads being formed with sergeants/verteran.sgts being promoted as required, should also work if you move a command squad into a new company.

also if you move veterans from the first company into any other you should see some of them being intergarated into teh command company as command company veterans

OH296 commented 10 months ago

make TODO notes and augmented to string interpolation