Allow renaming Marines - Githubissues

ZAB909 / ChapterMaster

11 stars 21 forks source link

Allow renaming Marines #217

Open GalacticChimp opened 7 months ago

GalacticChimp commented 7 months ago

Description

Enabling Marine renaming is flavorful, would definitely be nice to have that ability.

Proposed change

Allow renaming Marines (just in Company view should be enough)
obviously add validation (just check for empty. Players should be able to have Marines named the same, HOWEVER during sector generation names should get duplicated only rarely)

GalacticChimp commented 7 months ago

moved to 0.8.3.0 milestone, but it's tentative, we might not have enough time to do implement this, so it might get moved to 0.8.4.0

OH296 commented 7 months ago

Description

Enabling Marine renaming is flavorful, would definitely be nice to have that ability. However, this cannot be properly done until Marines are refactored into structs.

marines are already refactored into structs?

Also probably quite easy to fit this in i'll just rejiggle the code that allows you to rename companies and slap it on marines as long as teh player can't put "" as the name it should be fine

GalacticChimp commented 7 months ago

marines are already refactored into structs?

ok, I thought you were still doing some stuff with them. Ok, then this just got unblocked.

Updated issue description.

GalacticChimp commented 7 months ago

misclicked