search

ZAB909 / ChapterMaster

13 stars 29 forks source link

refactor: zoom and remove redundant was_zoomed #245

Closed jhillacre closed 10 months ago

jhillacre commented 11 months ago

Changes

  1. zoom logic was duplicated and is now centralized in src_zoom, for maintainability.
  2. refactor zoom logic to use else
  3. was_zoomed was removed after the above refactor, as it was then never read.
  4. replaced __view_set with the API view_set_visible for more direct view management.

The saves I made before removing was_zoomed still load after.

jhillacre commented 10 months ago

If someone who can merge would approve the approval, this PR is ready to merge.