search

ZATAN-uMaine / vismod

MIT License
2 stars 0 forks source link

Refactor Config Table and PreProcessor Class #134

Open tKharvud opened 4 months ago

tKharvud commented 4 months ago

Some parameters had to be hard-coded due to time-constraints and the equation used to calibrate values could also be made configurable.

Most importantly, the internal temperature coefficients should be moved to the config table, though this may require a refactor of the data_fetch module. As this may need to be done regardless, I suggest using the grad students config table instead of the colorful one, as it is more readily machine readable, modular, and straightforward. A new column can easily be added just like we did before for emails, with the added benefit that sensors can also be more easily added.

Dieff commented 4 months ago

This sounds good. Also, can we just remove the contact emails from the config sheet? Unless you really want to make them work.