Mostly organization suggestions

ZAdamMac / PETI

A project to brute-force-learn embedded product design techniques by creating a 90s-style virtual pet that runs on the MSP430FR5994 microcontroller.

GNU General Public License v3.0

5 stars 3 forks source link

Mostly organization suggestions #2

Closed kosmogen closed 3 years ago

kosmogen commented 3 years ago

Overall, your code looks fantastic! My suggestions are mostly code organization and cleanup. (We could probably also move some functions into different files to clean up main.c a little, but that's future work.)

I haven't tried to run this on the TI board I have but that's next and I'll let you know how it goes on my end!

ZAdamMac commented 3 years ago

I also don't see any issues with this feedback (which I appreciate) and I'm comfortable merging it to master. While it's technically untested the bulk of the changes are readability-oriented. The new function definitions are likely to go away during the next development push so I'm merging this now in anticipation of that and with the understanding that it's possible main.c winds up completely rewritten before the next release.