search

ZAdamMac / PETI

A project to brute-force-learn embedded product design techniques by creating a 90s-style virtual pet that runs on the MSP430FR5994 microcontroller.
GNU General Public License v3.0
5 stars 3 forks source link

[BUG] LED alert condition no longer clears after human input event. #28

Closed ZAdamMac closed 1 year ago

ZAdamMac commented 1 year ago

Behavior: The LED_ALERT LED remains lit after initially lighting, even once a human has interacted with the pet (e.g. by having touched an input button)

Expected behaviour: Pressing any of the input buttons should clear the LED alert light (by turning it off) until the next alert is triggered.

Likely this was caused when the human input stuff was changed in the previous megamerge.

ZAdamMac commented 1 year ago

Assigning to the work for FW version 0.2.0.

This regression escaped into the firmware on main because the LEDs on the primary test article were installed backwards. I wish I was kidding, but I'm really not.

Note for future me: this needs to be expressly called out in the development kit assembly instructions.

ZAdamMac commented 1 year ago

[f/rps-minigame 9d50feb] corrects this issue. the interacted_flag var from main.h was replaced with a HID_interacted_flag in the human input code, but main was not updated to interact with this and the ISRs for the various input devices were not updated to interact with this value either; commit corrects that.