search

ZBT-Tools / pemfc-dash-app

MIT License
2 stars 2 forks source link

Not all inputs are transferred to simulation #12

Closed fkuschel closed 1 year ago

fkuschel commented 1 year ago

Example: Multinputs under "Physical Properties"->

image

Debugging:

Inside first "Run Simulation" Button Callback: dash_functions.process_inputs() collects values properly. Thats why also "save results" and "load results" works fine. image

Inside next Callback "run_simulation()" data_transfer.gui_to_sim_transfer(input_data, settings) creates settings-dict for calculation. Default-values from local settings file are not overwritten. image

I'm looking into it.

fkuschel commented 1 year ago

Some details:

  1. Issue: Naming deviation: Dash App: ['anode', 'electrical_conductivity_gde'] GUI App: ['anode','gde', 'electric_conductivity'] --> Needs to be fixed in Dash app

  2. Issue: pemfc_gui.data_transfer.gui_to_sim_transfer() should be improved

    • give warning, if not all fields are updated.
    • do not allow creation of new entries by gui. --> Open separate issue in pemfc_gui

image

fkuschel commented 1 year ago

image

fkuschel commented 1 year ago

Definition in gui tabs image

lufire commented 1 year ago

solved in last PR