Idea: Move sim_app.simulation_api.py to settings

ZBT-Tools / simulation-web-app-template

Web app template providing user interface for typical simulation backends

MIT License

0 stars 0 forks source link

Idea: Move sim_app.simulation_api.py to settings #1

Open fkuschel opened 1 year ago

fkuschel commented 1 year ago

We should discuss this. simulation_api.run_external_simulation() is programm specific (call python module, open command line and run executable,...) and therefore should be in the settings folder.

lufire commented 1 year ago

I see the point and agree, however I'm not sure it is a good idea to mix config and native code files in one folder. Maybe it should be like this? (names and file formats to be replaced)

simulation_api 
|--settings/configs
|   |-- settings.json 
|   `-- parameters_layout.json
`--simulation
    `-- simulation_wrapper.py