search

ZDDduesseldorf / zdd-adventure-test

Student project to create an old-school text adventure.
MIT License
4 stars 4 forks source link

Add workflow for linting & testing #70

Closed adhamarif closed 1 year ago

adhamarif commented 1 year ago

Discussed in Issue #67 and #69.

A github actions is added for:

  1. Linting using flake8
  2. Unit test using Pytest
adhamarif commented 1 year ago

Removed requirement.txt because we don't have this file in our repository, as we only use the standard libraries in python for this project.

adhamarif commented 1 year ago

Update:

  1. Created requirement.txt in the repository.
  2. Added pip install -r requirement.txt back in the yaml file.
adhamarif commented 1 year ago

Really good point there! I just put the pytest in advance so that the next time someone make a pull request with their test function, the workflow is already available to test it in github.

But for now, I would remove the pytest as suggested because it seems like the test function would not be available for now and we would actually having a successful check if we remove pytest from the workflow.

adhamarif commented 1 year ago

pytest is removed and we have successful workflow for linting. All request have been considered and ready to be merged @florian-huber