ZDoom / Raze

Build engine port backed by GZDoom tech. Currently supports Duke Nukem 3D, Blood, Shadow Warrior, Redneck Rampage and Powerslave/Exhumed.
696 stars 59 forks source link

[BUG] [Blood CP] Some doors will not open #199

Closed duke912 closed 3 years ago

duke912 commented 3 years ago

On the very first level of cryptic, just after you enter the first door that needs a key, there's a switch that opens a wall between 2 pillars, but hitting the switch will do nothing. On the second floor of the same room, there's also a door that doesn't open, making it not possible to continue the level.

save0001.zip

Save is looking at the 'glitched' switch.

I remember running through similar problems in the main game level 'Ghost Town' a few days ago, where some doors will not open, or open once/twice before become buggy, mainly the elevator where the Super Secret of that level is.

sinisterseed commented 3 years ago

Shoot, this is nasty.

I've also checked the elevator you mentioned on E3M1, and it doesn't open indeed. There's also a crazy HOM in that room.

That crack in the wall where the Fanatics were also cannot be blown up.

brokenelevator.zip

Blood_0000

duke912 commented 3 years ago

Yep, a few minutes ago I could replicate the same bug in the second level of the first episode, just when you reach the station, you need to enter a booth to get a key, first time it opened fine but the cultist killed me, reloaded a save just before entering the station, but now the door will not open anymore, and not just that door, but any door inside the station.

coelckers commented 3 years ago

Can you please try to check if these problems only happen after reloading a savegame or also when the game runs normally. The Blood save code has been redone recently and there may be a bug in there.

sinisterseed commented 3 years ago

Yeah, I think this is related to the save system.

I just replayed CP01 and E3M1 in their entirety without saves, and I encountered no soft locks or broken secrets. This also appears to be consistent with what duke just said above, how the doors initially worked, but then broke after a reload.

That's also how I made that broken save. Like, literally. I saved and quit the game. When I came back, everything was broken.

duke912 commented 3 years ago

Just did a quick test and played the first level of CP without saving and both the switch and doors worked fine, but as soon as I quicksaved/reloaded then the bug just came back.

sinisterseed commented 3 years ago

Yep, that basically confirms it's a save issue.

coelckers commented 3 years ago

The non-opening doors should be fixed. I'm not sure about the HOM glitch, that may still be present. I also discovered one other problem: After saving the games some enemies stop their animation, after both loading and saving.

coelckers commented 3 years ago

Animations work again. I'd still like a confirmation for the HOM, I wasn't able to reproduce it even with the bugged code so I'm not sure what's up there.

sinisterseed commented 3 years ago

The HOM is still there, the map is actually a HOM glitchfest for some reason.

It glitches upstairs/downstairs, at the second crack after the elevator, and the top of the elevator is also a disaster.

Otherwise, things seem to be in order gameplay wise. But I'm going to check more maps to be sure all's fine.

Blood_0000 Blood_0001 Blood_0002

homfest.zip

sinisterseed commented 3 years ago

I found out what's causing the HOMs, but made a new ticket for it to investigate since I'm not sure about its relation to this issue, though it does appear to be connected to saving and reloading to some extent.

The HOMs appear when ending the game on a map (make sure you made a save on the respective map, this is required), starting another chapter, ending the game again, and loading the save you made on the other level.

After reloading, the ROR hackery will turn into a glitchfest.

sinisterseed commented 3 years ago

Also the softlock issues are not fully fixed.

Monster Bait from the base game makes an excellent map for testing these issues, and it breaks early on currently. If you fall into the river right at the start when the bridge collapses, there is a small elevator you can take back. The elevator itself still works, but the door never opens when interacting with it.

Additionally, after entering this room, the player is supposed to activate the two door switches, then press the one in the central panel to open the doors, but after pressing it the doors remain closed, rendering the map impossible to complete.

Blood_0000

There's also a puzzle at the very end of the map, and I have a feeling it's probably broken, but can't attest that since I can't get to it legitimately, and noclipping will help with nothing here as it will likely cause a few sequence breaks on the way.

broken monster bait.zip

duke912 commented 3 years ago

I just did a test and was able to replicate the 'door not opening' bug in the end of 'Cradle to Grave' on both latest dev version and in the artifact from here:

https://github.com/coelckers/Raze/runs/1465828688

After you enter the last door leading to exit, if you save/reload there, you can't go back to explore the level.

coelckers commented 3 years ago

I hope it is fixed - it's hard to test because none of the screenshots have coordinate info. Next time, please activate 'stat coord' before making a screenshot - that would simplify testing a lot because I could just use 'warptocoords'.

sinisterseed commented 3 years ago

I hope it is fixed - it's hard to test because none of the screenshots have coordinate info. Next time, please activate 'stat coord' before making a screenshot - that would simplify testing a lot because I could just use 'warptocoords'.

You're kidding me, I hope.

What do you think the saves were for 😉 .

coelckers commented 3 years ago

The problems are because the saves are broken, they abort with an error in debug mode.

sinisterseed commented 3 years ago

Fair enough.

Sadly, this is take a while to re-test. The problem here is that we fix it, it works in a map, then it turns out it doesn't in another. The only way to be sure it works 100% is to basically replay the entire game using saves. That's not a 5 minute job, so this will stay open for the time being until it's confirmed for sure.

duke912 commented 3 years ago

Just played the whole first episode with latest fix, and could not replicate the non-opening doors bug in any level, I'd say it's been fixed for good.

sinisterseed commented 3 years ago

We shall see, I'm on E2M3 now, and didn't notice it so far.

But who knows, better safe than sorry.

coelckers commented 3 years ago

I think this can be closed now.

sinisterseed commented 3 years ago

Yes, I was about to mention this.

I've played the first e chapters in their entirety and checkdd all boss maps as well.

No more softlocks, unless a random, highly specific instance was missed somehow. But I've not encountered any anymore.