ZDoom / Raze

Build engine port backed by GZDoom tech. Currently supports Duke Nukem 3D, Blood, Shadow Warrior, Redneck Rampage and Powerslave/Exhumed.
676 stars 59 forks source link

[BUG] Crash on Ubuntu 20.04.02 LTS with Fluidsynth #452

Closed m210 closed 3 years ago

m210 commented 3 years ago

I'm getting crashes after the intro logo on Ubuntu 20.04.02 LTS with KDE Plasma. Place "raze.sf2" in the game folder doesn't help. raze-crash.log

alexey-lysiuk commented 3 years ago

Update ZMusic to 1.1.8.

mjr4077au commented 3 years ago

@alexey-lysiuk I'm going to re-open this for now. m210 and I were discussing it on Discord just now, he did not have raze.sf2 in a soundfonts/ subdirectory. When he correctly placed the file, it worked fine. The SDL frontend for Raze/GZDoom should properly handle the lack of sf2 file like the win32 frontend does.

alexey-lysiuk commented 3 years ago

Where does Windows backend handle this? I have a suspicion that it doesn't crash just because of old FluidSynth without libinstpatch support.

mjr4077au commented 3 years ago

I'm sorry, you're probably right. Under windows it says "Could not find patch set raze", but this originates from ZMusic and not the game. I'll re-close again for now.

coelckers commented 3 years ago

Let's wait and see if upgrading to newer ZMusic will fix the crash. Obviously it should report a proper error and not outright crash when no patch set can be found. The crash occurs in Fluidsynth anyway so it looks like it's missing proper validation. Maybe on Windows the old DLL is just a bit more robust.

Still, we really need a better Linux setup so that these issues don't even happen.

alexey-lysiuk commented 3 years ago

The given crash is inside libinstpatch function that loads DLS sound font. Indeed, it's different from "usual" crashes because of FluidSynth library reloading. However, it's a mystery why it touches DLS loading code at all.