search

ZDoom / ZMusic

GZDoom's music system as a standalone library
https://forum.zdoom.org/index.php
64 stars 33 forks source link

Remove CMAKE_CROSSCOMPILING function #19

Closed ndowens closed 3 years ago

ndowens commented 3 years ago

This function caused cross-compile issues on Void, removing this function worked

madame-rachelle commented 3 years ago

Are you sure you want to go the route of removing it entirely? I presently use it to compile ARM executables for the related projects, and while indeed there are no native executables here that doesn't mean they will never exist.

I really would prefer to see the related errors fixed, rather than an entire system gutted like this.

coelckers commented 3 years ago

I classify this PR as a textbook non-fix to the existing problem, whatever that is as the OP doesn't go into details. So, no, won't apply without any further information.

ndowens commented 3 years ago

The problem that atleast removing this bit got rid of error “ IMPORT_EXECUTABLES” not found if cross building

madame-rachelle commented 3 years ago

That ... isn't even a bug.

When native compiling (at least with GZDoom and Raze) what happens is CMake generates a file called ImportExecutables.cmake - when you cross-compile for another architecture, you're supposed to point the crossed IMPORT_EXECUTABLES to a matching ImportExecutables.cmake from a native build.

The error is you not supplying such a file.

Sure - you don't need to import anything for this project since it does not generate native executables used for compile-time (i.e. zipdir) - but that's what it's there for.

madame-rachelle commented 3 years ago

I'm closing this. To resolve this we can deactivate the error itself and for this specific project only, until such a time compile-time executables might be needed, but the cross-compiling code should not be so haphazardly nor thoughtlessly removed like this.

ndowens commented 3 years ago

I'm closing this. To resolve this we can deactivate the error itself and for this specific project only, until such a time compile-time executables might be needed, but the cross-compiling code should not be so haphazardly nor thoughtlessly removed like this.

Yea I started rethinking of maybe proposing idea of adding an option that would enable/disable according to user choice

Blzut3 commented 3 years ago

Actually it's silly to keep this code in this project if it doesn't need it. Why make the CMakeLists more complex than it needs to be? Just re-add if it ever becomes a thing that's needed. In any case, no further action needed since my overhaul already removes this.